Namespaces

Variants

Share

Share
Views
Actions
Competitive Scene
Languages

Template talk:HeroNav

From Dota 2 Wiki
Jump to: navigation, search

Contents

[edit] Expand and Topmost on "Heroes" page

Can this template be placed at the top of the "Heroes" page and possibly the top of each individual hero? It is a much more concise way to navigate between pages but I am unsure how to do this.

Decency 12:29, 1 February 2012 (UTC)

It's at the bottom, if you have noticed. Redefining history 15:36, 1 February 2012 (UTC)
Yeah, I've seen. But when I want to quickly look at a list of heroes in Dota2, that's what I want to look at, and it's more difficult than need be to find. One wouldn't imagine it to be anything other than front and center on the "Heroes" page. I tried to edit the page myself to do so but I could not figure out how to change the state on initialization to be uncollapsed. Decency 08:22, 1 June 2012 (UTC)
{{HeroNav|uncollapsed}}. FWIW, a front-and-center HeroNav is what the Heroes page looked like in November 2011. I prefer it. --Kroocsiogsi 16:29, 1 June 2012 (UTC)
I've edited the page appropriately, it looks great to me. Thanks. Decency 14:57, 3 June 2012 (UTC)

[edit] Proposed revision

I propose replacing this template with the one found here: User:Kroocsiogsi/HeroNav. I've addressed several opinions and concerns already; more are welcome. --Kroocsiogsi 03:02, 30 April 2012 (UTC)

It links to each hero image. not links to hero page.(For example, i clicked Doom Bringer, there is not links to Doom Bringer But links to File:Doom Bringer.png --Gongwonchong 06:53, 1 May 2012 (UTC)
What version of what browser on what OS? --Kroocsiogsi 07:14, 1 May 2012 (UTC)
Well.. now fixed --Gongwonchong 08:05, 1 May 2012 (UTC)
Yeah, I think I tracked that down. Hope I didn't break anything else in the process. --Kroocsiogsi 08:22, 1 May 2012 (UTC)

[edit] Revision is complete

I have replaced previous hero navboxes with new versions.

Tested:

  • Across internationalizations
  • On all current major browsers on Windows 7

Advantages:

  • Arguably more elegant
  • Larger hero portraits
  • More symmetrical
  • Position of subtitles reflect in-game layout
  • No more heroes-ending-up-in-incorrect-rows at certain widths
  • No more balancing {{HeroNav/item|null}} stuff
  • Less whitespace at most widths, I think
  • Less total size at some widths (mostly larger widths)
  • Template:HeroNav and the new bits of common.css are clean code. Template:HeroNav/AlignmentFix is hacky, but simple.

Disadvantages:

  • More total size at some widths (mostly smaller widths)
  • Icons are larger, causing longer uncached pageload on slow connections
  • Names lack dropshadow in IE 9 and lower, making them less readable, although not unreadable. (IE doesn't give us a lot of traffic, but it might give us more if we catch on in China or something.)
  • Totally broken in IE 7 and lower, although other templates on the wiki have this problem too. IE 7 support might be possible if somebody has it installed. IE 6 support is probably hopeless.
  • Arguably less readable on all browsers, due to backgrounds
  • Untested with screenreaders
  • Template:HeroNav/item is horribly ugly code.

--Kroocsiogsi 00:44, 2 May 2012 (UTC)

[edit] Hero Order

Is there any specific reason why the heroes are ordered by release date rather than alphabetically? I guess the main advantage of release date order is that the newest heroes are last, which makes them stand out, but sorting by alphabetical order would be much more intuitive. I've seen non-wiki editors complain about this so it might be worth changing. --Pigbuster 05:17, 31 August 2012 (UTC)

We sort them how Valve sorts them, so it matches up with grid mode hero selection and the "Learn" page/tab. Alphabetical would make some sense, but I'd prefer we keep it to how Valve does it since that reflects the in-game ordering. -Baloroth 16:16, 31 August 2012 (UTC)